in reply to Re: Finding the max()/min()

in thread Finding the max()/min()

Your recursive version of max is broken for lists like (-1,0,1,2) and (-1,undef,1,2). i.e. the code assumes it is at the end of the list whenever $next==0 or $next==undef (which isn't true in general).
Here's a snazzy (if not the most efficient) recursive version with a hat tip to Zaxo...

-- All code is 100% tested and functional unless otherwise noted.

sub max { my ($x, @xs) = @_; @xs ? ($x, max(@xs))[$x < max(@xs)] : $x }

-- All code is 100% tested and functional unless otherwise noted.

Replies are listed 'Best First'. | |
---|---|

Re^3: Finding the max()/min()
by Ven'Tatsu (Deacon) on Nov 11, 2004 at 22:02 UTC |

In Section
Meditations

Comment onRe^2: Finding the max()/min()DownloadCode